Implement Send + Sync for LedCanvas #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a safety comment explaining why this is acceptable? I agree with your description in the PR, just would be good to have in the code as well. |
|
@StefanBossbaly , any update here? |
Since led_matrix_swap_on_vsync() will block until the next vsync, implementing the Send + Sync traits for LedCanvas will allow the canvas to be sent between a render thread and a draw thread. Since the underlying canvas is created with CreateFrameCanvas(), which allocates the canvas memory on the heap, it is safe to share between threads.
StefanBossbaly
force-pushed
the
feature-send-sync-canvas
branch
from
970c338 to
f8e156a
Compare
@TDHolmes sorry forgot about this. Added rustdoc in code for an explaination as to why this can be safely marked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Thanks for contributing! Please ensure
CHANGELOG.mdentryin the Unreleased section under the appropriate headingPull Request Description
Since led_matrix_swap_on_vsync() will block until the next vsync, implementing the Send + Sync traits for LedCanvas will allow the canvas to be sent between a render thread and a draw thread. Since the underlying canvas is created with CreateFrameCanvas(), which allocates the canvas memory on the heap, it is safe to share between threads.