Raise minimum supported Apple OS versions #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackHoleFox
commented
Dec 19, 2023
BlackHoleFox
force-pushed
the
legacy-apple-cleanup
branch
from
6dc685f
to
26faecc
Compare
|
Looks good! Please also add an appropriate CHANGELOG entry. |
BlackHoleFox
force-pushed
the
legacy-apple-cleanup
branch
from
26faecc
to
3fd7291
Compare
|
Added this entry to the CHANGELOG:
|
newpavlov
approved these changes
Jan 7, 2024
Merged
sammoore
added a commit
to paradigmpost/getrandom-legacy-macos
that referenced
this pull request
Jan 11, 2024
This reverts commit 5fe3c8e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of #371, and follows the new policy to significantly improve the two Apple OS backends of
getrandomnow that Rust has officially removed support for versions of macOS before 10.12, among others.The actual code changes are really a mirror of my work in
stdhere from a few months back. The two main things are:getentropyis now unconditionally linked on macOS since its assumed 10.12 is always the minimum deployment target. So macOS no longer needs theurandomfile reading logic.CCRandomGenerateBytes, which is part of CommonCrypto insidelibSystem.framework. This is the same function the previous SecRandomCopyBytes call wrapped around anyway, so other then dropping theSecurity.frameworkdependency its identical. Its also what BoringSSL uses if its need better selling.