-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.2.8 #294
Release v0.2.8 #294
Conversation
CHANGELOG.md
Outdated
## [0.2.8] - 2022-10-20 | ||
### Added | ||
|
||
- [Web Crypto API] can now be used on Node.js if avalible [#284] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new lines after subsection are redundant and not consistent with entries for other versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, and the other documentation, leave it ambiguous about which API will be used when both are detected. The big table in lib.rs's module doc is actively misleading, if I am understanding correctly that the webcrypto API is preferred if detected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. I've fixed the spacing and spelling issues. I've also moved the WebCrypto stuff to the Changed
section and actually elaborated on what we changed.
Let me know if it looks good to y'all.
I've also opened #295 to update the table in the Rust Docs.
Also updates the changelog Signed-off-by: Joe Richey <joerichey@google.com>
Merging this, now that #295 is merged. |
Also updates the changelog
We should probably release this before the major changes in #291
Signed-off-by: Joe Richey joerichey@google.com