Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings #502

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix clippy warnings #502

merged 2 commits into from
Oct 8, 2024

Conversation

phil-opp
Copy link
Member

@phil-opp phil-opp commented Oct 7, 2024

  • Break long doc paragraph
  • Elide explicit lifetimes when possible

Builds on top of #501, should be merged afterwards.

Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

  • Break long doc paragraph

FWIW the warning here is actually a false positive caused by the markdown links and I already opened an issue in clippy for this.

@phil-opp phil-opp force-pushed the remove-const_mut_refs-feature branch from 7278462 to d3e28e9 Compare October 7, 2024 19:55
@phil-opp phil-opp force-pushed the fix-clippy-warnings branch from ecccf11 to 1829dc1 Compare October 7, 2024 20:00
@phil-opp
Copy link
Member Author

phil-opp commented Oct 7, 2024

FWIW the warning here is actually a false positive caused by the markdown links and I already opened an issue in clippy for this.

Good to know! If you prefer, I can also remove the commit or add an #[allow] attribute.

Base automatically changed from remove-const_mut_refs-feature to master October 8, 2024 06:15
@Freax13
Copy link
Member

Freax13 commented Oct 8, 2024

FWIW the warning here is actually a false positive caused by the markdown links and I already opened an issue in clippy for this.

Good to know! If you prefer, I can also remove the commit or add an #[allow] attribute.

I think your change is fine. It seems reasonable to put additional notes onto a second paragraph and not in the first one. Rustdoc only shows the first paragraph in overviews, but the second line isn't needed for that.

@Freax13 Freax13 merged commit 323d46c into master Oct 8, 2024
11 of 13 checks passed
@Freax13 Freax13 deleted the fix-clippy-warnings branch October 8, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants