Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on promotion of PageTableEntry::new inside a const fn #175

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Don't rely on promotion of PageTableEntry::new inside a const fn #175

merged 2 commits into from
Sep 3, 2020

Commits on Sep 1, 2020

  1. Don't rely on promotion of PageTableEntry::new inside a const fn 

    Hi! Rust compiler team member here. When the `const_fn` feature is enabled, the implementation of `PageTable::new` relies on a compiler bug to work. Specifically, `PageTableEntry::new` should not be eligible for promotion as part of an array initializer. See rust-lang/rust#75502 for more information. This bug may be fixed in the future, which will cause this crate to stop compiling.
    @ecstatic-morse
    ecstatic-morse committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    52e5269 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Use internal constant to avoid accessing private entry field

    @phil-opp
    phil-opp committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    ef3d5c0 View commit details
    Browse the repository at this point in the history