Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefi-macros: Change uefi dev-dependency from version to path #998

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

nicholasbishop
Copy link
Contributor

Using a path avoids having to update the uefi-macros dep on uefi after releasing a new version of uefi, slightly simplifying our release process.

Prior to cargo 1.40 there was no choice but to have a version on dev-dependencies. That changed with
rust-lang/cargo#7333, and now you can publish a crate with a path-only dev dependency.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

Using a path avoids having to update the `uefi-macros` dep on `uefi` after
releasing a new version of `uefi`, slightly simplifying our release process.

Prior to cargo 1.40 there was no choice but to have a version on
dev-dependencies. That changed with
rust-lang/cargo#7333, and now you can publish a crate
with a path-only dev dependency.
@phip1611
Copy link
Contributor

Love it, nice! Great catch

@phip1611 phip1611 added this pull request to the merge queue Nov 12, 2023
Merged via the queue into rust-osdev:main with commit 546dc14 Nov 12, 2023
12 checks passed
@nicholasbishop nicholasbishop deleted the bishop-improve-dev-dep branch November 12, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants