xtask: Fix channel of cargo operations #464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-fix-xtask
branch
2 times, most recently
from
50a7d90 to
a679279
Compare
It seems that some recent change (in cargo? or maybe rustc or rustup) broke the way we run cargo from xtask. The channel arg (e.g. "+nightly") is getting ignored due to the RUSTC env var and other similar vars, which contain full paths to a particular channel's binaries. Fix by unsetting those variables in the child cargo's env.
nicholasbishop
force-pushed
the
bishop-fix-xtask
branch
from
a679279 to
d7d170c
Compare
|
Looks like others are seeing similar problems: rust-lang/rustup#3029 Unsetting |
|
Closing in favor of #466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some recent change (in cargo? or maybe rustc or rustup)
broke the way we run cargo from xtask. The channel arg (e.g. "+nightly")
is getting ignored due to the RUSTC and RUSTDOC env vars, which contain
full paths to a particular channel's binaries.
Fix by unsetting those variables in the child cargo's env.