Add an additional MB of space to the generated FAT partition

[kennystrawnmusic]

Increasing the image size by an additional megabyte makes the image compile again

Fixes #396

[Freax13]

Is that increasing the size by a terabyte? Note that the expression in the parentheses is already multiplied by MB, so now it ends up being (... + MB) * MB, which should be a TB if I'm not mistaken. Replacing the 1 by a 2 is probably a more storage efficient fix 😀

[kennystrawnmusic]

Alright, doing something else then, hold on…

[kennystrawnmusic]

Alright, I decided to revert it back to what it was before and instead simply append + MB to the end of that long calculation, since adding a megabyte is far more reasonable than multiplying.

[kennystrawnmusic]

Finally got this down to one commit but it took git reset --hard <the first of my previous commits> and git pull https://github.com/rust-osdev/bootloader main --allow-unrelated-histories --rebase to do it.

[Freax13]

Could you remove the first commit?

[Freax13]

A revert commit is still a commit, ideally we'd only have a single commit for this pr. See https://stackoverflow.com/a/42522493 on how to remove commits without creating a revert commits.

[phil-opp]

Looks good, thanks!

I updated the PR title to be more descriptive and added the line Fixes #396 to the PR description to automatically close the issue after merging.

One minor request: Right now the title of your commit is "Hard reset per @Freax13's request", which is not really useful. Could you change it to something more descriptive? An easy way to do this is to run the following command:

git commit --amend --message "Add an additional MB of space to the generated FAT partition"

[phil-opp]

To me it's more readable without the extra parentheses:

Suggested change

	let fat_size_padded_and_rounded = (((needed_size + 1024 * 64 - 1) / MB + 1) * MB) + MB;
	let fat_size_padded_and_rounded = ((needed_size + 1024 * 64 - 1) / MB + 1) * MB + MB;

[kennystrawnmusic]

Had to use a hard reset and force-push to incorporate both of these changes without also inadvertently turning 1 commit into 2, but done.

[phil-opp]

Thanks!

[phil-opp]

By the way, I recommend to use git rebase --interactive (or git rebase -i for short) to squash and reword commits. It's much easier to use than git reset --hard in my opinion. For some basic examples, check out e.g. https://www.sitepoint.com/git-interactive-rebase-guide/ .