-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UEFI: Add support for different framebuffer configs on real hardware vs VMs #364
Closed
Closed
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
a2fc6ce
Refactor UEFI implementation for compliance with rust-lang/rust#10745…
kennystrawnmusic fd818fc
rustfmt
kennystrawnmusic 57bd85d
rust-osdev/bootloader#360: Resolve @phil-opp's concerns (1/5)
kennystrawnmusic ec7cbaa
rust-osdev/bootloader#360: Resolve @phil-opp's concerns (2/5)
kennystrawnmusic d18076e
rust-osdev/bootloader#360: Resolve @phil-opp's concerns (3/5 + 4/5)
kennystrawnmusic 5d153e3
Update tests/runner/src/lib.rs
kennystrawnmusic 02ecbb2
Fix unused import warning
phil-opp 2aa4abf
Merge branch 'rust-osdev:main' into master
kennystrawnmusic 84d3f62
Use highest resolution available on real hardware
kennystrawnmusic d8d4b9c
rustfmt
kennystrawnmusic ccb8bb2
Merge branch 'rust-osdev:main' into master
kennystrawnmusic 16330cd
#364: Use different configs for VMs vs real hardware
kennystrawnmusic 2f66e58
#364: rustfmt
kennystrawnmusic fb182e7
Merge branch 'rust-osdev:main' into master
kennystrawnmusic 299a670
Pass the UEFI runtime services table address to the BootInfo if runni…
kennystrawnmusic 68a123e
Pass the UEFI runtime services table address to the BootInfo if runni…
kennystrawnmusic c5b6e04
rustfmt
kennystrawnmusic 31f77fa
Merge remote-tracking branch 'origin/patch-1'
kennystrawnmusic 0b028db
Remove redundant dependencies
kennystrawnmusic 35bcae6
Add back the Copy and Clone impls
kennystrawnmusic 5578f36
Fix doc comments
kennystrawnmusic 20dbee7
rustfmt
kennystrawnmusic 82ea900
Merge commits pushed to pull request
kennystrawnmusic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,3 +16,4 @@ log = "0.4.14" | |
x86_64 = "0.14.8" | ||
serde-json-core = "0.5.0" | ||
uefi = "0.20.0" | ||
raw-cpuid = "10.7.0" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit puzzled about what this PR is doing.
I often use VMWare and QEMU/KVM for running guest VMs as I would a host, especially when enabling paravirtualization features for performance similar to host system. These guests may run windowed or fullscreen.
It's not too concerning for me as this is only applicable to a bootloader based on this project, but the motivation seems focused on QEMU windowed for development/testing purposes?
As a user, if I have a VM guest fullscreen on a display(s), I'd find this different implicit behaviour a bit confusing, especially since there's an exception made for Xen.
I don't think you find GRUB, rEFInd, or systemd-boot handling resolution used differently? I believe they have a config setting if you want to explicitly prefer a resolution or scaling/fit?
I'm not that familiar with the project, but is this just a default with a way to opt-out? Is there actual value in a physical + virtual framebuffer structs that this PR introduces for this distinction?
Or would it be better to match what other bootloader/managers do, and just provide a default with build (or runtime) config to have the scaling behaviour you prefer?
You could then more easily build for your VM testing, with a different config for production builds on real hardware (or VM guests). The detection to switch based on environment if desired beyond testing may be better served as an opt-in feature/config?
If you disagree, no worries 👍
Maybe consider documenting the behaviour then so it's easier to troubleshoot when a dev/user encounters it and tries to understand why it scales differently on most hypervisors.