-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bitwise operations with primitive ints #211
base: master
Are you sure you want to change the base?
Conversation
Just because we can, doesn't mean we should, and this would be the only operator that mixed |
You're right; I hadn't realized that the other operations would have such an issue until after I'd written the |
Correct me if I'm wrong, but Update: wait I realized my mistake lol. The PR is about mixed-type bit ops, so a primitive |
I still think the mixed signed-ness is too confusing, let's drop that. |
Fixes #205.
This does not add bitwise-or and bitwise-xor operations between signed integers and BigUint, because there is no good way to represent negative numbers with a BigUint (see #184). Bitwise-and operations were added because the result of such an operation will always be positive.