Make encrypt_private_zap_message pub #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
private-zaps
branch
from
a7ed5c7 to
5bc7193
Compare
yukibtc
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on adding public/private zaps for mutiny. Since we support the NIP-07 signer we need to be able to create private zap events manually, to do so we need this function public.
Also would like to make it so
private_zap_requestdoesn't take in a&Keys, seems like it is only needed forcreate_encryption_keybut don't really see why it is done that way, could just useKeys::generate, I guess the main reason is so we can decrypt it ourself