New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Mark all public struct/enum as non_exhaustive" #25

Open

hch12907 wants to merge 1 commit into rust-netlink:main from hch12907:nonexhaustive

hch12907 commented Jan 4, 2025

This reverts commit 53a4c4e.

While the idea of having forward compatibility was sound, the commit effectively disallowed any Netlink message to be created:

    let mut packet = NetlinkMessage {
        header: NetlinkHeader {
            sequence_number: 1,
            flags: NLM_F_DUMP | NLM_F_REQUEST,
            ..Default::default()
        },
        payload: RtnlMessage::GetLink(LinkMessage::default()).into(),
    };

error[E0639]: cannot create non-exhaustive struct using struct expression

This is just silly.


          Revert "Mark all public struct/enum as non_exhaustive"

93794e3

This reverts commit 53a4c4e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet