Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to turn on/off blas backend #385

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

kateinoigakukun
Copy link
Contributor

@kateinoigakukun kateinoigakukun commented Nov 18, 2024

ndarray by default turns off blas backend, but ndarray-linalg turns it on by default and there is no way to turn it off. This change adds a cargo feature to control it. It's a default feature, so users who don't want to use blas backend need default-features = false in their Cargo.toml.

This change allows us to use this crate on WebAssembly.

ndarray by default turns off blas backend, but ndarray-linalg turns
it on by default and there is no way to turn it off. This change adds
a cargo feature to control it. It's a default feature, so users who
don't want to use blas backend need `default-features = false` in
their Cargo.toml.
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (7213ae8) to head (6879eb2).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   86.85%   86.88%   +0.02%     
==========================================
  Files          64       64              
  Lines        3584     3584              
==========================================
+ Hits         3113     3114       +1     
+ Misses        471      470       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dirreke Dirreke merged commit c62ff0c into rust-ndarray:master Jan 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants