New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax requirement for DataMut on SVDCC #303

Merged

termoshtt merged 1 commit into rust-ndarray:master from benkay86:master

Aug 28, 2022

Contributor

benkay86 commented Jul 27, 2021

The SVDDCInto trait should require self to be DataMut, but for the SVDDC trait we only need self to be Data since we do not own it.


          Relax requirement for DataMut on SVDCC

429d14e

termoshtt merged commit 57393b2 into rust-ndarray:master

Member

termoshtt commented Aug 28, 2022

Thanks!

This is a breaking change since public API changes. But most user code does not change because DataMut struct always implements Data.

termoshtt added the change label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change