Port usage of uninitialized to build_uninit #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
commented
May 13, 2021
| let mut a = replicate(&av); | ||
| Zip::indexed(&mut a).for_each(|(i, j), elt| { | ||
| if i > j { *elt = A::zero() } | ||
| }); | ||
| a |
There was a problem hiding this comment.
This PR has an inefficiency here since zero elements are overwritten after copying (not benchmarked, in some cases probably faster/just as fast because the indexed iterator is slow).
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 89.01% 89.01%
=======================================
Files 71 71
Lines 3577 3578 +1
=======================================
+ Hits 3184 3185 +1
Misses 393 393
Continue to review full report at Codecov.
|
build_uninit is necessary for abstracting over any kind of owned array. The version of take_slice_upper is still inefficient in one way (overwriting after copying), but could likely still be an improvement upon the previous version.
jturner314
approved these changes
May 27, 2021
|
I merged this because it looks good to me, we really need to release a new version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_uninit, is necessary for abstracting over any kind of owned array here.
Fixes #277
Requires ndarray 0.15.2