Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for solve-factorized #240

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Add test for solve-factorized #240

merged 1 commit into from
Jul 28, 2020

Conversation

termoshtt
Copy link
Member

Resolve #228

The bug has been fixed in #213. This PR adds a test to confirm it

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #240 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   88.97%   89.07%   +0.09%     
==========================================
  Files          71       71              
  Lines        3574     3588      +14     
==========================================
+ Hits         3180     3196      +16     
+ Misses        394      392       -2     
Impacted Files Coverage Δ
ndarray-linalg/tests/solve.rs 100.00% <100.00%> (ø)
lax/src/solve.rs 100.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c027ef0...9c86af7. Read the comment docs.

@termoshtt termoshtt merged commit e0664f1 into master Jul 28, 2020
@termoshtt termoshtt deleted the bug-228 branch July 28, 2020 17:52
@termoshtt termoshtt added this to the 0.13.0 milestone Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly a bug in linear solve with column major layout?
1 participant