Revise tests for least-square problems #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test for complex case should be added for #220 |
termoshtt
force-pushed
the
least-square-test
branch
2 times, most recently
from
dff5631 to
9742c57
Compare
termoshtt
changed the title
termoshtt
force-pushed
the
least-square-test
branch
from
50e52f2 to
7e3cd8b
Compare
termoshtt
force-pushed
the
least-square-test
branch
from
d79606c to
6bbe87d
Compare
|
Matrix layout issue will be treated in lax crate rather than ndarray-linalg in #206. This C/F mixed case should be handled in lax also. |
termoshtt
commented
Jul 24, 2020
Comment on lines
+28
to
+32
| #[test] | ||
| fn [<least_squares_ $scalar _exact>]() { | ||
| let a: Array2<f64> = random((3, 3)); | ||
| test_exact(a) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Includesplit Add LeastSquaresSvdDivideConquer_ into Lapack trait #232LeastSquaresSvdDivideConquer_intoLapacktraitTODO
bwith transpose and complexbFix C/F mixed caseskeep C/F mixed cases unsupported Support C/F mixed case for least-square problem #234