Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trait for linear operator #159

Merged
merged 6 commits into from
Jun 16, 2019
Merged

Trait for linear operator #159

merged 6 commits into from
Jun 16, 2019

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Jun 15, 2019 •
edited
Loading

Replace operator::Operator* traits by new LinearOperator trait.

  • Switch arnoldi module to use it instead of Fn(&mut ArrayBase<S, Ix1>)
  • diag, and its dependent (eigh) module are affected.

Design

  • There is no need to split these traits since there are &self functions
    • LinearOperatorOnce with self functions (with Clone) can be an option
  • Do not support general D: Dimension.
    • Dimension::Smaller is not match for the action of linear operators onto any rank tensor.
  • rename op* to apply*, multi to 2

@termoshtt termoshtt added the breaking change Non-compatible change label Jun 16, 2019
@termoshtt termoshtt marked this pull request as ready for review June 16, 2019 18:59
@termoshtt termoshtt merged commit cf68301 into master Jun 16, 2019
@termoshtt termoshtt deleted the linear_operator branch October 13, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change Non-compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@termoshtt