cargo-apk: Inherit package configuration (version) from workspace root
#360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
MarijnS95
force-pushed
the
inherit-version-from-workspace
branch
from
1427a3d to
bccad23
Compare
msiglreith
approved these changes
Nov 5, 2022
MarijnS95
force-pushed
the
inherit-version-from-workspace
branch
from
bccad23 to
f31c73f
Compare
|
I'll merge this in when closer to a |
Starting with [Rust 1.64] common `[package]` parameters (and dependencies) can now be specified in the workspace root manifest by setting `<field>.workspace=true` in a `[package]` and specifying its value in the workspace root manifest under [`[workspace.package]`]. Since `cargo-apk` reads the `version` field from `[package]` it has to support this new format and pull the value from the root manifest instead, in order to support projects utilizing this new format. This is currently implemented ad-hoc for the version field, but could be done in a cleaner way if/when more fields are needed. [Rust 1.64]: https://blog.rust-lang.org/2022/09/22/Rust-1.64.0.html#cargo-improvements-workspace-inheritance-and-multi-target-builds [`[workspace.package]`]: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-workspacepackage-table
MarijnS95
force-pushed
the
inherit-version-from-workspace
branch
from
f31c73f to
4d9101a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rust-mobile/cargo-subcommand#23, rust-mobile/cargo-subcommand#24
Fixes #359
Starting with Rust 1.64 common
[package]parameters (and dependencies) can now be specified in the workspace root manifest by setting<field>.workspace=truein a[package]and specifying its value in the workspace root manifest under[workspace.package].Since
cargo-apkreads theversionfield from[package]it has to support this new format and pull the value from the root manifest instead, in order to support projects utilizing this new format.This is currently implemented ad-hoc for the version field, but could be done in a cleaner way if/when more fields are needed.