-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-apk: Automate adb reverse
port forwarding through Cargo.toml
metadata
#348
cargo-apk: Automate adb reverse
port forwarding through Cargo.toml
metadata
#348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have the example from the readme added in our manifest example
Updated the readme in 4638053 |
cargo-apk/README.md
Outdated
|
||
# Set up reverse port forwarding through `adb reverse`, meaning that if the | ||
# Android device connects to `https://localhost:1338` it will be routed to | ||
# the localhost on the host device instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't strictly for http
, I'd write Android device connects to `localhost` on port `1338` ...
.
For demonstration purposes, can we use a different source and destination purposes? e.g. it will be routed to the host on port `XYZ whatever you choose` instead.
I still don't feel entirely confident about having this in |
For us, in practice, it means a significantly smoother and less error prone workflow for launching apk's, regardless of how much it has to do with building an apk or not, for us it's fundamental to running one which is why I'm proposing adding this to this tool. |
Sure, and as said above we don't really have any clean/proper alternative. At the same time we're one of the very few actively contributing to I'll apply the nits above and merge this, not sure when I'll push out a new (patch) release though ( |
adb reverse
in the Cargo.tomladb reverse
port forwarding through Cargo.toml
metadata
Fixes #231
This adds a feature so we can set up reverse port forwarding from our Cargo.toml file before the app starts