Add AAudio interface #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need tests and examples, so that we can run miri to detect ub one day. But for the time being they still don't support ffi calls. |
|
@dvc94ch Makes sense, I'm wondering how the testing setup would look like. I suppose tests would need to run on an Android emulator to have access to the native binaries. Do you have anything in mind already? |
|
Not really, I just know I had issues with segfaults when using jni-bindgen and I assume it's because our safe wrappers invoke ub somehow. There are some links in #28, but that's as far as my research went. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bindings for Android NDK's AAudio interface (part of #22).
Also fixes an issue with previous PR where
*mut JNIEnvpointers were getting dereferenced which doesn't as I expected.