Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back to trying the file when retrieving the build id for a binary #134

Closed
afranchuk opened this issue Sep 4, 2024 · 0 comments · Fixed by #135
Closed

Fall back to trying the file when retrieving the build id for a binary #134

afranchuk opened this issue Sep 4, 2024 · 0 comments · Fixed by #135

Comments

@afranchuk
Copy link
Contributor

If the build id of a binary isn't available in memory (which seems to at least sometimes be the case on Android), we should try to load the associated file to get the build id (as opposed to calculating one).
afranchuk added a commit to afranchuk/minidump-writer that referenced this issue Sep 4, 2024
@afranchuk
Try to read the build id from the mapping file if reading from the
8ccbf1b 
process memory fails.

We could potentially generalize this behavior to occur for SONAME as
well, however it's likely unnecessary.

Closes rust-minidump#134.
@afranchuk afranchuk mentioned this issue Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@afranchuk