Add items and adjust existing ones to the evolving standard #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xFrednet
added
A-api
xFrednet
commented
Nov 11, 2022
| #[repr(C)] | ||
| #[non_exhaustive] | ||
| #[derive(Copy, Clone, Eq, PartialEq, Debug)] | ||
| pub enum UseKind { |
There was a problem hiding this comment.
Update UseItem to be like described in the reference and not how rustc handles it. This will also remove this enum
xFrednet
changed the title
7 tasks
|
I'm almost ready to create the next PR. I'll merge this one to rebase :) bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was quite fun to write. It's remarkable how a good framework and setup can come together for fast and effective development :3
This closes #49, the driver implementation will be done in as part of #53. This issue also removes almost all traits from our API 🎉. The last trait will be removed with #51 this therefore also closes #6. Also, as usual, some progress on #38.
The normal disclaimer: I'm happy about reviews, but will merge this, if there has been no activity by the time I want to create the next PR. Let's hope this progress keeps up.
Closes #49
Closes #6 (The last will be removed as part of #51 )
CC: #53