Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine polish section impact, define milestones #233

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Refine polish section impact, define milestones #233

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f5306d
Refine polish section impact, define milestones
eholk Aug 26, 2021
1f48014
Link to 'must not suspend' lint RFC
eholk Aug 27, 2021
526baeb
Code review feedback
eholk Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 33 additions & 3 deletions src/vision/roadmap/polish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,37 @@

## Impact

* Users can predict and understand why the compiler raises error messages. Errors are aligned with an experienced user's intuition about how Rust works.
* Error messages identify common misconceptions, suggest solutions, and are generally on par with sync Rust.
* Errors not only show that there is a problem, they help the user to fix it and to learn more about Rust (possibly directing the user to other documentation).
* The compiler may suggest crates from the ecosystem to help solve problems when appropriate.
* Lints guide the user away from common errors and help them both to get started with async Rust and to maintain async Rust programs over time.
* Errors not only show that there is a problem, they help the user to fix it and to learn more about Rust (possibly directing the user to other documentation).
* The generated code from the compiler is high quality and performant.
* Integration with low-level tooling and the like is high-quality.
* Rust's async implementation is high quality and reflects an attention to detail.
* No internal compiler errors
* Compiler analysis and code generation passes are precise and not unnecessarily conservative.
* Integration with low-level tooling and the like is high-quality.
* The generated code from the compiler is high quality and performant.

## Milestones

| Milestone | State | Key participants |
| --- | --- | --- |
| Precise generator captures | 🦀 | [eholk] |
| ↳ Prototype | 🦀 | [eholk] |
| ↳ Documented in Rust Reference | 🦀 | [eholk] |
| ↳ [Lang team] signoff | 💤 | [Lang team] |
| ↳ Stabilized | 💤 | [eholk] |
| Lint: [Large copies], large generators | 💤 | |
| ↳ [Lang team] initiative proposal | 💤 | |
eholk marked this conversation as resolved.
Show resolved Hide resolved
| ↳ Implementation | 💤 | |
| Lint: [Must not suspend] | 💤 | |
| ↳ Landed the [RFC] | 💤 | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs implementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rephrase as "Implemented the RFC." The RFC is already merged, so I think all we need to do is implement what the RFC says.

| Lint: [Blocking in async context] | 💤 | |
eholk marked this conversation as resolved.
Show resolved Hide resolved


[eholk]: https://github.com/eholk/
[Lang team]: https://www.rust-lang.org/governance/teams/lang
[Blocking in async context]: ./polish/lint_blocking_fns.md
[Large copies]: ./polish/lint_large_copies.md
[Must not suspend]: ./polish/lint_must_not_suspend.md
[RFC]: https://rust-lang.github.io/rfcs/3014-must-not-suspend-lint.html