This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Fix use_crate_blacklist error #643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
to rust-lang/rls
that referenced
this pull request
Aug 11, 2019
Warn against deprecated config entries Addresses rust-lang/vscode-rust#643. Brings back removed option from #1509 but only not to trigger the unknown option warning.
bors
added a commit
to rust-lang/rls
that referenced
this pull request
Aug 11, 2019
Warn against deprecated config entries Addresses rust-lang/vscode-rust#643. Brings back removed option from #1509 but only not to trigger the unknown option warning.
|
Thanks for the PR! I don't think this is a correct fix - we should warn the user about deprecated option (which is what rust-lang/rls#1539 does) instead. As such, I'll close this (see #639 (comment) for more details) |
matklad
added a commit
to matklad/vscode-rust
that referenced
this pull request
Jul 13, 2020
643: add gc request r=matklad a=matklad Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #639