Handle r? as assignment

[kellda]

Rewrite of #433 for current master

r? @Mark-Simulacrum

[Mark-Simulacrum]

Thanks!

This is primarily stalled on custom roles on the GitHub side, as we would like to avoid giving triagebot admin access org-wide (or configuring each repository individually with triagebot when adding reviewers to that repository).

[kellda]

Thanks for that infromation, seems resonable not wanting to make triagebot admin. However

• Isn't write access enough ? (Or is write access the same as admin ?)
• Isn't this just an alias to the assign command ?
• Does rust-highfive have more permissions than triagebot ?

[Mark-Simulacrum]

Write access is indeed enough for each repository, but there's no current org-level way to grant that to triagebot AFAIK (without making it an admin, or a service that would adjust permissions like that on all repositories under rust-lang). Highfive currently needs to be configured for each repository too, AFAIK, but if we triagebot and highfive overlap on commands they can receive (in particular for this PR, r?) then we'll end up seeing double comments/assignments etc which isn't going to end well -- and highfive unlike triagebot does not support gradual enable/disable of features.

I have not reviewed the particular implementation here, but IIRC r? generally behaves somewhat differently I believe from assign in some cases. In particular highfive's r? (probably correctly) does not permit review assignment for non-org members (who don't have r+ anyway). But I'd need to think about the right thing here to be able to answer in more detail.

[kellda]

Thanks for the explanation.

As said, this is just a rebase/rewrite of #433 you wrote half a year ago. Here r? behaves almost like @triagebot assign (i.e. it is only parsed differently).

[fmease]

This can be closed since the functionality is now implemented, right?