Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt rustlings team as a subteam of lang-docs #1638

Merged

Conversation

traviscross
Copy link
Contributor

@traviscross traviscross commented Jan 6, 2025

We're doing some minor reorganization. As part of that, we're moving the book team and rust-by-example to be subteams of lang-docs. Given that, it makes sense for lang-docs to also adopt rustlings as a subteam, so let's do that.

Note that, unlike the other two, rustlings had been notated as a marker team rather than a subteam of launching-pad. This change will make it into a normal subteam, which seems more appropriate.

As discussed in the PR (#1638 (comment)), apparently mo8it has been maintaining rustlings solo for about nine months, so this PR also makes him a lead of the team.

cc @ehuss @shadows-withal @mo8it @jamesmunns

@traviscross traviscross force-pushed the TC/adopt-rustlings-under-lang-docs branch from 21d6a19 to 40e0f0f Compare January 6, 2025 21:16
We're doing some minor reorganization.  As part of that, we're moving
the book team and rust-by-example to be subteams of lang-docs.  Given
that, it makes sense for lang-docs to also adopt rustlings as a
subteam, so let's do that.

Note that, unlike the other two, rustlings had been notated as a
marker team rather than a subteam of launching-pad.  This change will
make it into a normal subteam, which seems more appropriate.
@traviscross traviscross force-pushed the TC/adopt-rustlings-under-lang-docs branch from 40e0f0f to 4d1464f Compare January 6, 2025 21:19
people/mo8it.toml Outdated Show resolved Hide resolved
teams/rustlings.toml Outdated Show resolved Hide resolved
In the PR, mo8it provided these details to be included.
Apparently, as discussed on the PR, mo8it has been maintaining
rustlings solo for about nine months, so it makes sense to make him
a lead of the team.

We can handle any other membership adjustments we might want to make
separately and later.
@traviscross
Copy link
Contributor Author

traviscross commented Jan 6, 2025

@jamesmunns and I had a good talk. He suggested that it would be valuable to add some further context to this PR.

The first bit of context is that I'm making this PR with my lang-docs, lang, and lang-ops hats on -- that is, the hat of a member of the adopting team, its parent team, and the team that supports that parent team and tends to handle many administrative and policy matters like this -- not with my council hat on.

Regarding the lang-docs hat, while, in practice, @ehuss and I tend to handle much of the coordination work for lang-docs, this should of course be approved by one or both of the current leads for lang-docs, @ehuss and/or @JohnTitor. This PR can be seen as my suggestion to my fellow team members about the appropriate handling. As it is, @ehuss and I had discussed this ahead of time, and he has approved it in #1638 (review).

I was prompted to make this PR by @chriskrycho following up to my proposal in rust-lang/leadership-council#123 after talking with @carols10cents regarding the handling of the book team. With that resolved, and that PR up in #1636, it seems clear that rustlings should be handled in the same way, and that the next step is for the adopting team to adopt the team to be adopted, so that's what this PR proposes to do.

On the council side, @jamesmunns is of course the one coordinating this, and is of course in my view doing a great job in that. Thanks to James for opening the tracking issues, for bringing the various parties together, and for updating the council on all the various progress on this endeavor.


Putting on my council hat for a moment, I suppose we might consider the question of whether each of (or each specific batch of) these moves requires an FCP from the council. My own feeling is that it's probably not necessary to require such process for moves of a group out from under launching-pad, where both the group and the adopting team agree on the handling (and where no other potentially-adopting team is making a claim), especially given our preexisting consensus that moving such groups out from launching-pad to more appropriate teams is what we'd like to see happen. But I'm curious to hear what @jamesmunns thinks, and if it's at all unclear we should of course raise this topic in our next council meeting on 2025-01-17.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, thank you for your work!

Copy link
Member

@shadows-withal shadows-withal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@rylev rylev merged commit 94cfefb into rust-lang:master Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants