Add #[rustc_args_required_const] annotations #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW this is blocked on rust-lang/rust#48078 reaching nightlies |
| @@ -96,6 +96,7 @@ pub unsafe fn _mm256_or_ps(a: __m256, b: __m256) -> __m256 { | |||
| #[inline] | |||
| #[target_feature(enable = "avx")] | |||
| #[cfg_attr(test, assert_instr(vshufpd, imm8 = 0x1))] | |||
| #[rustc_args_required_const(2)] | |||
There was a problem hiding this comment.
It looks like supporting attributes attached directly to function parameters would help with cases like this.
*Adds it to the list of things to implement some time*
alexcrichton
force-pushed
the
const
branch
3 times, most recently
from
e78e13a to
a46b0d2
Compare
Support isn't quite in nightly to make this work yet, but using a local build this gets everything passing again! This also implements native verification that we have the attribute in the right place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support isn't quite in nightly to make this work yet, but using a local build
this gets everything passing again! This also implements native verification
that we have the attribute in the right place