Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wasm f*_sqrt() doc #1692

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Fix Wasm f*_sqrt() doc #1692

merged 1 commit into from
Dec 21, 2024

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Dec 15, 2024

Caught in rust-lang/rust#134333.

While trying to figure out why this what not caught in the CI, I was unable to reproduce the error locally, cargo doc --target wasm32-unknown-unknown doesn't seem to do the trick. Maybe something to do with how stdarch interacts with core I don't understand.

@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Amanieu
Copy link
Member

Amanieu commented Dec 21, 2024

You need to enable the rustdoc::broken-intra-doc-links lint which I believe is not enabled by default. See https://stackoverflow.com/questions/70511431/how-can-i-make-the-rustdocbroken-intra-doc-links-lint-an-error-from-the-comm.

@daxpedda
Copy link
Contributor Author

daxpedda commented Dec 21, 2024

You need to enable the rustdoc::broken-intra-doc-links lint which I believe is not enabled by default.

Apologies, I should have mentioned, I already tried that by adding #![deny(rustdoc::broken_intra_doc_links)] and RUSTDOCFLAGS=-Drustdoc::broken_inta_doc_links. Also tried with rustdoc::all (which showed a bunch of other issues, but not that one, which I also made sure of by temporarily fixing all the other issues).

I also made sure that the functions were compiled in the first place by adding a compile_error! inside a function, which correctly triggered. Also added #![feature(wasm_numeric_instr)] just to stave off any lingering paranoia.

@Amanieu
Copy link
Member

Amanieu commented Dec 21, 2024

Fair enough, I don't know why it isn't working then.

@Amanieu Amanieu added this pull request to the merge queue Dec 21, 2024
Merged via the queue into rust-lang:master with commit 684de0d Dec 21, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants