-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime detection of VEX variants of AVX512 #1586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayantn
changed the title
Add some new target features for x86
Runtime detection of VEX variants of AVX512
Jun 18, 2024
sayantn
force-pushed
the
veorq
branch
2 times, most recently
from
June 19, 2024 15:02
004f7a5
to
f1553d6
Compare
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 20, 2024
Expand `avx512_target_feature` to include VEX variants Added 5 new target features for x86: - `AVX-IFMA` - `AVX-NE-CONVERT` - `AVX-VNNI` - `AVX-VNNI_INT8` - `AVX-VNNI_INT16` Both LLVM and GCC already have support for these. See also the [stdarch PR](rust-lang/stdarch#1586)
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jun 21, 2024
Expand `avx512_target_feature` to include VEX variants Added 5 new target features for x86: - `AVX-IFMA` - `AVX-NE-CONVERT` - `AVX-VNNI` - `AVX-VNNI_INT8` - `AVX-VNNI_INT16` Both LLVM and GCC already have support for these. See also the [stdarch PR](rust-lang/stdarch#1586)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 21, 2024
Expand `avx512_target_feature` to include VEX variants Added 5 new target features for x86: - `AVX-IFMA` - `AVX-NE-CONVERT` - `AVX-VNNI` - `AVX-VNNI_INT8` - `AVX-VNNI_INT16` Both LLVM and GCC already have support for these. See also the [stdarch PR](rust-lang/stdarch#1586)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 21, 2024
Expand `avx512_target_feature` to include VEX variants Added 5 new target features for x86: - `AVX-IFMA` - `AVX-NE-CONVERT` - `AVX-VNNI` - `AVX-VNNI_INT8` - `AVX-VNNI_INT16` Both LLVM and GCC already have support for these. See also the [stdarch PR](rust-lang/stdarch#1586)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 21, 2024
Rollup merge of rust-lang#126617 - sayantn:veorq, r=workingjubilee Expand `avx512_target_feature` to include VEX variants Added 5 new target features for x86: - `AVX-IFMA` - `AVX-NE-CONVERT` - `AVX-VNNI` - `AVX-VNNI_INT8` - `AVX-VNNI_INT16` Both LLVM and GCC already have support for these. See also the [stdarch PR](rust-lang/stdarch#1586)
Expanded the cache size to 93 (we will need this in near future) Fixed detection of VAES, GFNI and VPCLMULQDQ Could not test with `cupid` because they do not support these yet
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Jun 28, 2024
Expand `avx512_target_feature` to include VEX variants Added 5 new target features for x86: - `AVX-IFMA` - `AVX-NE-CONVERT` - `AVX-VNNI` - `AVX-VNNI_INT8` - `AVX-VNNI_INT16` Both LLVM and GCC already have support for these. See also the [stdarch PR](rust-lang/stdarch#1586)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added run-time detection for 5 new x86 target features. Expanded the Cache size to 93.
AVX-IFMA
AVX-NE-CONVERT
AVX-VNNI
AVX-VNNI_INT8
AVX-VNNI_INT16
Fixed run-time detection of
VAES
,GFNI
,VPCLMULQDQ
(they do not needAVX512
support, the 512-bit versions needAVX512F
, and that should be handled in target-feature attributes of the intrinsics.See also the rustc PR