Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test expectations for aarch64 #1528

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Feb 16, 2024

vcgez/vclez now generate different (and more obvious) instructions.

fmadd/fmsub are now preferred over the slower fmla/fmls in more cases. I believe this is specific to the LANE=0 case, but I couldn't figure out how to switch testing to use LANE=1 without also breaking the case where only LANE=0 is valid.

@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@nikic
Copy link
Contributor Author

nikic commented Feb 16, 2024

I believe the fma change is llvm/llvm-project@38c92c1. I didn't try to track down the other one.

@Amanieu Amanieu merged commit 44dbe95 into rust-lang:master Feb 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants