Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std_detect: add avx512fp16 #1508

Merged
merged 1 commit into from
Feb 24, 2024
Merged

std_detect: add avx512fp16 #1508

merged 1 commit into from
Feb 24, 2024

Conversation

usamoi
Copy link
Contributor

@usamoi usamoi commented Dec 12, 2023

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2023

r? @Amanieu

(rustbot has picked a reviewer for you, use r? to override)

@usamoi usamoi force-pushed the avx512fp16 branch 2 times, most recently from 7628825 to db0cdbc Compare December 12, 2023 09:04
@Amanieu
Copy link
Member

Amanieu commented Dec 19, 2023

CI should be fixed now, can you rebase?

@usamoi
Copy link
Contributor Author

usamoi commented Dec 19, 2023

CI passed.

@Amanieu
Copy link
Member

Amanieu commented Jan 2, 2024

I noticed that avx512fp16 is missing from the list of target features in rustc. Additionally, adding a new feature will require an FCP. I think the best way forward is for you to submit a PR to add this target feature to rustc, at which point we can start an FCP on that PR which will cover both the target feature and the feature detection in stdarch.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 3, 2024
add avx512fp16 to x86 target features

std_detect avx512fp16: rust-lang/stdarch#1508
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2024
Rollup merge of rust-lang#119543 - usamoi:avx512fp16, r=oli-obk

add avx512fp16 to x86 target features

std_detect avx512fp16: rust-lang/stdarch#1508
@usamoi
Copy link
Contributor Author

usamoi commented Feb 6, 2024

avx512fp16 is in the list of target features in latest nightly rustc now. Is an FCP still required? @Amanieu

@Amanieu
Copy link
Member

Amanieu commented Feb 14, 2024

This is fine to merge, but we're waiting on rust-lang/rust#121088 to fix CI-related issues.

GuillaumeGomez pushed a commit to GuillaumeGomez/rustc_codegen_gcc that referenced this pull request Feb 15, 2024
add avx512fp16 to x86 target features

std_detect avx512fp16: rust-lang/stdarch#1508
@usamoi usamoi force-pushed the avx512fp16 branch 4 times, most recently from f05f4c8 to 895da3c Compare February 21, 2024 05:14
Signed-off-by: usamoi <usamoi@outlook.com>
@Amanieu Amanieu merged commit fb7df64 into rust-lang:master Feb 24, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants