Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The doc-test for __m256 is wrongly guarded by #[target_feature(enable = "sse")] #481

Closed
kennytm opened this issue Jun 21, 2018 · 2 comments
Closed

The doc-test for __m256 is wrongly guarded by #[target_feature(enable = "sse")] #481

kennytm opened this issue Jun 21, 2018 · 2 comments

Comments

@kennytm
Copy link
Member

kennytm commented Jun 21, 2018

... it should be "avx".

https://github.com/rust-lang-nursery/stdsimd/blob/5d300a55cf521a035f40c1ef9869ed277c055312/coresimd/x86/mod.rs#L278-L286

See rust-lang/rust#51675 for detail.
gnzlbg added a commit to gnzlbg/stdsimd that referenced this issue Jun 21, 2018
@gnzlbg
fix doc-test for __m256. Closes rust-lang#481
1a4fd99
@gnzlbg gnzlbg closed this as completed in 6256448 Jun 21, 2018
@mnd
Copy link

mnd commented Jun 22, 2018

@gnzlbg Is line /// # if is_x86_feature_detected!("sse") { unsafe { foo() } } should be changed too?

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 22, 2018 •
edited
Loading

@mnd thanks for keeping an eye on things! It was changed in the next commit: 6626729

TheIronBorn pushed a commit to TheIronBorn/stdsimd that referenced this issue Jun 29, 2018
@gnzlbg
fix doc-test for __m256. Closes rust-lang#481
e15d12b
TheIronBorn pushed a commit to TheIronBorn/stdsimd that referenced this issue Jun 29, 2018
@gnzlbg
fix doc-test for __m256. Closes rust-lang#481
0aae0c3
@mnd mnd mentioned this issue Jul 4, 2018
Closed
lu-zero pushed a commit to lu-zero/stdarch that referenced this issue Jul 10, 2018
@gnzlbg @lu-zero
fix doc-test for __m256. Closes rust-lang#481
576bea0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kennytm @gnzlbg @mnd