Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is F16C still unstable? #1234

Closed
netizen-a opened this issue Oct 20, 2021 · 4 comments · Fixed by #1366 or rust-lang/rust#106323
Closed

Why is F16C still unstable? #1234

netizen-a opened this issue Oct 20, 2021 · 4 comments · Fixed by #1366 or rust-lang/rust#106323

Comments

@netizen-a
Copy link

I noticed that most x86_64 intrinsics were stable, yet F16C isn't. I'd like to know what is keeping it from hitting stable, and what can be done to make it stable. According to another tracking issue comment there doesn't seem to be anything blocking it.

@netizen-a netizen-a changed the title Why is F16C still unstable? Why is F16C still unstable? Oct 20, 2021
@Amanieu
Copy link
Member

Amanieu commented Nov 5, 2021

There is no specific reason, just that nobody has pushed for its stabilization yet. In this case all that would be needed is a PR to add stability attributes to these function to stabilize them.

@aloucks
Copy link

aloucks commented Dec 5, 2021

It's odd that the runtime check seems to think it was stablized in 1.27.0:

@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] f16c: "f16c";

It looks like this was missed:
https://github.com/rust-lang/rust/blob/887999d163bace7e79370b952bdd1f930ff4cdd5/compiler/rustc_feature/src/active.rs#L241

Does it just need to be moved here?:
https://github.com/rust-lang/rust/blob/887999d163bace7e79370b952bdd1f930ff4cdd5/compiler/rustc_feature/src/accepted.rs

@Amanieu
Copy link
Member

Amanieu commented Dec 5, 2021

The feature detection was stabilized separately from the intrinsics.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 12, 2023
…ature, r=petrochenkov

Stabilize f16c_target_feature

Resolves rust-lang/stdarch#1234

Library PR for stabilizing corresponding intrinsics: rust-lang/stdarch#1366

See also rust-lang#44839 tracking issue for target_feature
RalfJung pushed a commit to RalfJung/miri that referenced this issue Jan 13, 2023
…petrochenkov

Stabilize f16c_target_feature

Resolves rust-lang/stdarch#1234

Library PR for stabilizing corresponding intrinsics: rust-lang/stdarch#1366

See also #44839 tracking issue for target_feature
@Amanieu Amanieu reopened this Jan 22, 2023
@Amanieu
Copy link
Member

Amanieu commented Jan 22, 2023

The F16C intrinsics aren't stable yet, this is still waiting on FCP in #1366.

thomcc pushed a commit to tcdi/postgrestd that referenced this issue May 31, 2023
…petrochenkov

Stabilize f16c_target_feature

Resolves rust-lang/stdarch#1234

Library PR for stabilizing corresponding intrinsics: rust-lang/stdarch#1366

See also #44839 tracking issue for target_feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants