Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TCP_CONGESTION socketopt #371
Add support for TCP_CONGESTION socketopt #371
Changes from 4 commits
1018c40
6a59ab6
fba1185
9ac17bc
64dd03b
d2bbbee
0d2c2ed
21c2452
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is UB. Only
&buf[0..len]
bytes are initialised by the kernel.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not resolved. You can't call
payload.assume_init
, it's not fully initialised. I think you can simply remove this line and we're good.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so now I use directly
[u8; TCP_CA_NAME_MAX]
(initialized as[0; TCP_CA_NAME_MAX]
) instead ofMaybeUninit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not what I asked for, but fine for now.
Allow me to explain the UB in the old code one more time. You create an array of size
TCP_CA_NAME_MAX
, accessing any of those by would be UB. Then you call the kernel to fill the bytes, but it doesn't fill all of them justn
bytes (return by the system call). With the old code you calledpayload.assume_init()
, which requires the entire array all (TCP_CA_NAME_MAX
bytes) to be initialised, but that's not always the case as it's only up ton
bytes.So the only change needed to the old code was to remove the
payload.assume_init()
line. Because the next line creating a slice of only the initialised bytes and the line after that cast it to a slice of bytes (MaybeUninit<u8>
->u8
).