Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to error-chain 0.5.0 to allow optional backtrace. #591 #703

Merged
merged 3 commits into from
Sep 30, 2016
Merged

Update to error-chain 0.5.0 to allow optional backtrace. #591 #703

merged 3 commits into from
Sep 30, 2016

Conversation

squidpickles
Copy link
Contributor

Thought I'd give this a try. No test failures, and it does seem to short-circuit a bunch of system calls with RUST_BACKTRACE=0.

@squidpickles
Copy link
Contributor Author

This is a fix for #591
Not sure about the build failures. Tests passed locally on Mac and Linux, but I don't have access to a Windows box to debug on. Is this likely a related issue?

@brson
Copy link
Contributor

brson commented Sep 3, 2016

@squidpickles Awesome! This looks great.

The linux failure is because on the bots cargo build is causing Cargo.lock to be updated, which is considered an error. And I've verified that when I build locally the lockfile also changes. Can you try locally and see if you get the same result, and if so update the lockfile.

Since the build on travis is pinned to nightly-2016-08-10 you might want to try running rustup override set nightly-2016-08-10 to make sure you've got the same configuration.

The windows failure looks spurious.

Thanks!

@squidpickles
Copy link
Contributor Author

Looks like the Cargo.lock update fixed that problem. And, I've got the nightly running in that directory. Thanks for the help with my help.

@brson brson merged commit 1a4bbe9 into rust-lang:master Sep 30, 2016
@brson
Copy link
Contributor

brson commented Sep 30, 2016

Thank you again. Sorry for leaving this for so long 😧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants