Skip to content

test: detach snapshots from component installation order #4435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Aug 3, 2025

Currently, quite a few of our test snapshots rely on the messages sent to our notification center similar to the following:

info: downloading component 'cargo'
info: downloading component 'rust-docs'
...
info: installing component 'cargo'
...

... however, the order will no longer be guaranteed once @FranciscoTGouveia makes these events concurrent, meaning there will be a different CLI output format which doesn't guarantee the order of such events.

This PR has made such snapshots agnostic to the specific forms of these message, and turn to other means such as rustup component list --installed if necessary.

Concerns

@rami3l rami3l force-pushed the test/install-order-agnostic branch from ca17faf to 2497645 Compare August 4, 2025 15:06
@rami3l rami3l requested review from djc and ChrisDenton August 4, 2025 15:07
@rami3l rami3l marked this pull request as ready for review August 4, 2025 15:08
@rami3l rami3l added this pull request to the merge queue Aug 5, 2025
Merged via the queue into rust-lang:master with commit e43263a Aug 5, 2025
29 checks passed
@rami3l rami3l deleted the test/install-order-agnostic branch August 5, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants