-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curl #436
Closed
Closed
Curl #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately the move to rust-native-tls has had some hiccups on Windows and Hyper also currently doesn't support features like HTTP proxies (but support's coming soon!). For now this temporarily moves over to using libcurl to weed out these problems until we get to a point where we're hyper's features are more filled out. This also somewhat aligns with Cargo as well which is using libcurl currently. This does not use the `curl` crate on crates.io because it doesn't support streaming downloads. Instead I've got an in-progress rewrite which is just binding much more directly to libcurl's APIs (e.g. exposing the callback functions directly). This branch is in a git repo currently and I hope to upstream it to curl-rust soon as well.
Seems like it can't find 'make'? |
Yeah I think that's the fix, although I believe the path is |
Failing for yet new reasons. |
@@ -21,6 +24,12 @@ on_finish: | |||
- ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1')) | |||
|
|||
install: | |||
- if defined MSYS_BITS set PATH=C:\msys64\mingw%MSYS_BITS%\bin;C:\msys64\usr\bin;%PATH% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/MSYS_BITS/BITS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #434