Fix shell check warning #3121
Merged
Fix shell check warning #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustin170506
force-pushed
the
rustin-patch-shell-check
branch
2 times, most recently
from
ec53374 to
b5541c3
Compare
|
Hi! so SC1091 means shellcheck couldn't read the file. I can't see those action logs they are too far back; perhaps we can see them somewhere else? I think it would be good to fix the problem rather than disabling the checks. |
Rustin170506
force-pushed
the
rustin-patch-shell-check
branch
from
b67b540 to
cbea87d
Compare
rbtcollins
reviewed
Jan 10, 2023
rbtcollins
reviewed
Jan 10, 2023
rbtcollins
reviewed
Jan 10, 2023
rbtcollins
reviewed
Jan 10, 2023
rbtcollins
reviewed
Jan 11, 2023
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Rustin170506
force-pushed
the
rustin-patch-shell-check
branch
from
79f29e9 to
c69e6a2
Compare
|
Thank you for all the work on this |
|
Thanks for your review! 💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/rust-lang/rustup/actions/runs/3622731921/jobs/6133180965
It may be that our shell checker is updated.
SC1091 is pretty annoying and it prints some warning in our test scripts. So I excluded it.