Clarify shell restarting message #2684
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone who supplies a `no_modify_path` option requires less clarification.
rbtcollins
reviewed
Feb 28, 2021
src/cli/self_update.rs
Outdated
| To get started you need Cargo's bin directory ({cargo_home}/bin) in your `PATH` | ||
| environment variable. Next time you log in this will be done | ||
| automatically. | ||
| To get started you may need to log out and back in. |
There was a problem hiding this comment.
Perhaps. ...out and back in, or start a new shell. (We've changed what we do on unix since these message was written, and any new shell will now affect PATH.
rbtcollins
requested changes
Feb 28, 2021
Restarting the shell is now enough. Relogging restarts the shell so we don't need to suggest relogging.
rbtcollins
approved these changes
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2681.