Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated GitHub Actions commands. #2513

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 8, 2020

The old method of using ::set-env and ::add-path have been deprecated, see https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/.

This includes a second commit to work around a GitHub Actions cache bug on macOS.

@ehuss ehuss force-pushed the github-deprecated-action-commands branch 6 times, most recently from 9950423 to 41caa7d Compare October 8, 2020 17:19
@ehuss ehuss force-pushed the github-deprecated-action-commands branch 3 times, most recently from c3a893c to 4f8182d Compare October 8, 2020 18:29
@ehuss ehuss force-pushed the github-deprecated-action-commands branch from 4f8182d to f048a68 Compare October 8, 2020 19:07
@ehuss
Copy link
Contributor Author

ehuss commented Oct 8, 2020

Note that CI caching is not really working for any job that doesn't set SKIP_TESTS. I filed rust-lang/cargo#8762 with a description of the problem. This will be somewhat mitigated by rust-lang/cargo#8755 which should be on nightly (that will fix CI caching, but all the dependencies are still being built twice). Some workarounds would be:

  • Add lto to [profile.bench].
  • Don't use --release when running tests.

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. It's always nice when things change under us 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants