Allow current dir for component unpack #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have a formatting bogon (trailing comma) and I wonder if it's possible to construct at least one of the test tarballs with a |
|
Personally I wouldn't worry about the test path at this point - it will be a chunk of work, and we know the requirement now. I would like a comment explaining that old tarballs have this content in them and we want to support them. |
|
Yep that's fair. So a comment explaining so that we don't accidentally remove the support seems best. |
|
@rbtcollins I've rebased this and added the comment, how do you feel about merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2263. Simple fix as mentioned by @kinnison in the original issue.