-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Rust favicon #2419
Adds Rust favicon #2419
Conversation
Where did these image files come from? |
|
Assuming we're allowed to cross-link with the relevant content policies etc, it may make more sense to just reference them from www.rust-lang.org then, rather than copying them over. |
I've updated |
@pietroalbini What would it take to deploy this to dev- so that we can verify the favicons work like this? |
@kinnison we need to do the dev promotion of a release. |
hmm, not the easiest thing to do with a prospective change then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. However could add metatags for favicons and stuff too
I'm sorry it has taken so long to come back to this. At worst if this doesn't work then it simply won't work, right? Or will it cause browsers to complain to users? |
If this does not work I don't think users will see an explicit error from browsers. Still, we should try this out before doing the prod promotion. |
Okay, I'll merge this and we should remember to check it during the 1.24 release process |
Adds favicons to minimally support Chrome, Firefox, and Safari browsers.