Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for misspelled component name #1823

Closed
wants to merge 2 commits into from
Closed

Suggestion for misspelled component name #1823

wants to merge 2 commits into from

Conversation

hrvolapeter
Copy link
Member

Add suggestion for misspelled component name using Levenshtein distance

Closes #1816

r? @kinnison

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly pretty good, just a couple of requests.

I also would prefer that you don't put r? @kinnison in the commit message since that ends up in the repo long-term. By all means tag me in the PR message though.

Would you like to extend this to also support making a suggestion if the user tries to add/remove a target which is misspelled?

src/toolchain.rs Outdated Show resolved Hide resolved
src/toolchain.rs Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented May 7, 2019

☔ The latest upstream changes (presumably #1833) made this pull request unmergeable. Please resolve the merge conflicts.

@kinnison
Copy link
Contributor

kinnison commented May 9, 2019

The changes in this PR were subsumed into #1824 and merged. Thank you for your contribution to Rustup.

@kinnison kinnison closed this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make suggestions based on Levenshtein distance
4 participants