Handle more EPIPE situations #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be easier for scripts to use us, until we define a proper CLI API for that, handle EPIPE situations on all the list type subcommands as well as the show subcommands. Fixes rust-lang#1730 Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
das-sein
approved these changes
Apr 16, 2019
|
Thanks for the review. |
fnichol
added a commit
to fnichol/workstation
that referenced
this pull request
Apr 23, 2019
When checking for an installing plugins, there isn't a need to call cargo for each plugin to check. While this is just-as-good as previous behavior, it also limits any issues when calling a Cargo subcommand that might fail. Presently, there are times where a race exists and either `STDOUT` or `STDERR` might disppear when Rustup (or potentially Cargo) is used in a shell pipeline, leading to a program panic with `failed printing to stdout: Broken pipe (os error 32)`. This change tries to minimize the probability that this occurs until a more robust upstream fix has landed. References: rust-lang/rustup#1730 References: rust-lang/rustup#1765 Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be easier for scripts to use us, until we define a
proper CLI API for that, handle EPIPE situations on all the list
type subcommands as well as the show subcommands.
Fixes #1730
Signed-off-by: Daniel Silverstone dsilvers@digital-scurf.org