Simplify host triplet passing code #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
force-pushed
the
simplify-host-triplet-passing-code
branch
3 times, most recently
from
34fd7b2 to
726bab9
Compare
nrc
reviewed
Feb 10, 2019
nrc
reviewed
Feb 10, 2019
src/rustup-dist/build.rs
Outdated
| .unwrap() | ||
| .write_all(target.as_bytes()) | ||
| .unwrap(); | ||
| println!("cargo:rerun-if-changed=build.rs"); |
There was a problem hiding this comment.
Looks like my comment was lost: I thought we would need to keep this directive in order to avoid unnecessary rebuilds?
There was a problem hiding this comment.
I was torn about whether to assume this was still necessary or whether it was legacy cruft. Looks like I went with the latter assumption. I'll recover it and we can dump it another day if need be.
dwijnand
force-pushed
the
simplify-host-triplet-passing-code
branch
from
726bab9 to
2067d36
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.