-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print default toolchain on rustup default
without arguments
#1633
Conversation
Hey, @lazorgator. Thanks for sending the PR. Want to update the tests so we can assess how this implementation behaves? |
Yep, sorry about that! Working on them now for both PRs. |
@dwijnand Should be all set. I only needed to modify one test. However, I noticed that it was possible to be in a state wherein no default toolchain was set in the settings. This required modification of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @lazorgator. The patch seems reasonable to me. I'd merge it if I could. So let's see if this matches @nrc's expectations in #1632.
r? @nrc |
1774cd3
to
7f347f2
Compare
I'm very sorry, but I messed up and wrote |
5ac007f
to
8babd1a
Compare
@nrc Alright, added the functionality to |
Perhaps it's best to remove it from |
rustup update
without argumentsrustup default
without arguments
8babd1a
to
ec7b52f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-LGTM
Awesome, thanks! |
Does this duplicate |
@dwijnand It does I think! I'll work on a PR to just make the |
Implementation of #1632
Behavior: When
rustup default
is not provided arguments, print the default toolchain (new behavior) before commencing updates of all installed toolchains.