Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry mode hangs if there are too many errors #639

Closed
arielb1 opened this issue Aug 4, 2016 · 3 comments · Fixed by #645
Closed

telemetry mode hangs if there are too many errors #639

arielb1 opened this issue Aug 4, 2016 · 3 comments · Fixed by #645

Comments

@arielb1
Copy link

arielb1 commented Aug 4, 2016

Meta

$ rustup -V
rustup 0.5.0 (4be1012 2016-07-30)
$ rustc -V
rustc 1.12.0-nightly (0a3180baa 2016-08-03)
$ cat ~/.multirust/settings.toml 
default_host_triple = "x86_64-unknown-linux-gnu"
default_toolchain = "nightly"
telemetry = true 
version = "12"

[overrides]

STR

$ for i in $(seq 1 10000); do echo "fn fail() {}"; done >> so-much-fail.rs
$ rustc so-much-fail.rs 

Expected Result

10000 errors are printed to standard error

Actual Result

hang, since telemetry_rustc (https://github.com/rust-lang-nursery/rustup.rs/blob/4be1012/src/rustup/command.rs#L51) pipes stderr and waits, without reading from it.

moved from rust-lang/rust#34535

@brson
Copy link
Contributor

brson commented Aug 4, 2016

Thanks for filing this. Telemetry is very underbaked right now and I don't recommend anybody use it.

@aidanhs
Copy link
Member

aidanhs commented Aug 9, 2016

Just because it could break things or because it might accidentally be collecting all of my hard drive? If the former that's fine, in general I feel capable of debugging issues if I hit them (though @arielb1 saved me for this one).

@TimNN
Copy link
Contributor

TimNN commented Aug 10, 2016

Just ran into this, very annoying to debug, although I did learn a bit more about lldb.

TimNN added a commit to TimNN/rustup.rs that referenced this issue Aug 10, 2016
TimNN added a commit to TimNN/rustup.rs that referenced this issue Aug 10, 2016
TimNN added a commit to TimNN/rustup.rs that referenced this issue Aug 10, 2016
TimNN added a commit to TimNN/rustup.rs that referenced this issue Aug 10, 2016
nodakai pushed a commit to nodakai/rustup.rs that referenced this issue Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants