-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can’t install Rust 1.7 #502
Comments
Confirming, all of the pre-1.8.0 channel description files (and corresponding hashfiles) are now missing from https://static.rust-lang.org/dist, so rustup.rs (and probably the old multirust?) now error when trying to install anything between 1.0 and 1.7, or when doing a bulk-update with these channel having been installed previously. |
rustup is supposed to fallback to a different download strategy for versions prior to 1.8 (there are no manifest files for them), but it seems that fallback has broken recently. |
Rust pre-1.8.0 didn't have any manifests, so this leads to status 404. Only error `CURLE_FILE_COULDNT_READ_FILE` was mapping to `Download404` though, so a "successful" status 404 was causing rustup to give up on old versions entirely. Now status 404 is mapped correctly too, and the manifest fallbacks work correctly. Fixes rust-lang#487. Fixes rust-lang#502.
Is this really fixed? I tried installing v1.7.0 on a new machine today:
I'm using the latest released rustup:
The commit that should have fixed this was merge before the release date (though that doesn't mean it was on that release, it probably is). Can anyone confirm? Edit: just noticed the URL errors with 403, so maybe something changed on how files are served that caused rustup to break since the fix seems to deal on how to handle a 404. |
It was definitely working for a while, but yes it seems broken anew, differently. I've noticed that https://static.rust-lang.org/dist/ now returns a 0-byte binary, whereas /dist//index.html still works. Then anything that should be 404 like /dist/foo is instead a 403. I guess we could fix rustup so that 403 (or maybe any 4xx) status will also retry with the fallback. That's seems like a big kludge though... |
Does it actually need a fallback mechanism? What if it was hardcoded for But anyway, I understand it's not exactly a bug on rustup, but more on the distribution. Nonetheless something broke. What's the best way to bring people that work on the distribution to this conversation? |
Ideally the fix should work for old nightlies too (#487). I suppose that could use a hardcoded date range. |
The text was updated successfully, but these errors were encountered: