Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inform what version rustup was updated from #2110

Closed
tesuji opened this issue Nov 4, 2019 · 5 comments · Fixed by #2143
Closed

Inform what version rustup was updated from #2110

tesuji opened this issue Nov 4, 2019 · 5 comments · Fixed by #2143
Labels
E-easy E-mentor enhancement help wanted
Milestone
1.21.0

Comments

@tesuji
Copy link
Contributor

tesuji commented Nov 4, 2019 •
edited
Loading

Currently rustup update outputs:

% rustup update
info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2019-11-04, rust version 1.40.0-nightly (b520af6fd 2019-11-03)
[REDACTED]
  stable-x86_64-unknown-linux-gnu unchanged - rustc 1.38.0 (625451e37 2019-09-23)
   nightly-x86_64-unknown-linux-gnu updated - rustc 1.40.0-nightly (b520af6fd 2019-11-03)

It would be nice if rustup could print out which version it was updated from:

% rustup update
info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2019-11-04, rust version 1.40.0-nightly (b520af6fd 2019-11-03)
[REDACTED]
  stable-x86_64-unknown-linux-gnu unchanged - rustc 1.38.0 (625451e37 2019-09-23)
   nightly-x86_64-unknown-linux-gnu updated - rustc 1.40.0-nightly (b520af6fd 2019-11-03) from rustc 1.40.0-nightly (aa69777ea 2019-10-29)

Meta

rustup -V: rustup 1.20.1 :: 1.20.0+14 (4eadfff 2019-10-15)
@chansuke
Copy link
Contributor

chansuke commented Nov 5, 2019

Hi, I would like to take this issue

@kinnison
Copy link
Contributor

kinnison commented Nov 6, 2019

Hi @chansuke,

I'm sorry it took so long to respond. Thank you for being interested in this enhancement request. You should pop along to our discord: https://discord.gg/cKdYFVz (#wg-rustup) and we can discuss how you go about this, if you're not confident to go ahead without guidance.

Thanks again, and welcome to Rustup.

D.

@chansuke
Copy link
Contributor

chansuke commented Nov 9, 2019

@kinnison Thank you. I will check discord channel.

@kinnison kinnison added this to the 1.21.0 milestone Nov 10, 2019
@payload
Copy link
Contributor

payload commented Nov 25, 2019

Hi @chansuke. Are you still working on this issue?

@joshtriplett
Copy link
Member

Minor nit on formatting: please make the "from" version less prominent (e.g. parenthetical), so that it's easier to quickly scan the line for the version and distinguish the old and new versions.

RobbieClarken added a commit to RobbieClarken/rustup that referenced this issue Dec 4, 2019
@RobbieClarken
Output the previous version of a toolchain when it is updated
b9279d4 
Fixes rust-lang#2110
RobbieClarken added a commit to RobbieClarken/rustup that referenced this issue Dec 4, 2019
@RobbieClarken
Output the previous version of a toolchain when it is updated
21806e1 
This change modifies the cli output of `rustup update` to display the
previous version of rustc for toolchains that are updated:

    $ rustup update

    stable-x86_64-apple-darwin unchanged - rustc 1.39.0 (4560ea788 2019-11-04)
    nightly-x86_64-apple-darwin updated - rustc 1.41.0-nightly (7afe6d9d1 2019-12-03) (from rustc 1.40.0-nightly (22bc9e1d9 2019-09-30))

Fixes rust-lang#2110.
@RobbieClarken RobbieClarken mentioned this issue Dec 4, 2019
Merged
RobbieClarken added a commit to RobbieClarken/rustup that referenced this issue Dec 5, 2019
@RobbieClarken
Output the previous version of a toolchain when it is updated
08370ae 
This change modifies the cli output of `rustup update` to display the
previous version of rustc for toolchains that are updated:

    $ rustup update

    stable-x86_64-apple-darwin unchanged - rustc 1.39.0 (4560ea788 2019-11-04)
    nightly-x86_64-apple-darwin updated - rustc 1.41.0-nightly (7afe6d9d1 2019-12-03) (from rustc 1.40.0-nightly (22bc9e1d9 2019-09-30))

Fixes rust-lang#2110.
RobbieClarken added a commit to RobbieClarken/rustup that referenced this issue Dec 6, 2019
@RobbieClarken
Output the previous version of a toolchain when it is updated
8a0b4ae 
This change modifies the cli output of `rustup update` to display the
previous version of rustc for toolchains that are updated:

    $ rustup update
    --snip--
      stable-x86_64-apple-darwin unchanged - rustc 1.39.0 (4560ea788 2019-11-04)
       nightly-x86_64-apple-darwin updated - rustc 1.41.0-nightly (7afe6d9d1 2019-12-03) (from rustc 1.40.0-nightly (22bc9e1d9 2019-09-30))

Closes rust-lang#2110.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy E-mentor enhancement help wanted
Projects
None yet
Milestone
1.21.0
Development

Successfully merging a pull request may close this issue.

Output the previous version of a toolchain when it is updated RobbieClarken/rustup
5 participants
@payload @joshtriplett @chansuke @kinnison @tesuji